Skip to content

Deprecate Locator(link: Link) in favor of Publication.locate(Link) #47

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
May 10, 2022
Merged

Deprecate Locator(link: Link) in favor of Publication.locate(Link) #47

merged 6 commits into from
May 10, 2022

Conversation

@mickael-menu
Copy link
Member

@mickael-menu mickael-menu commented Apr 27, 2022

Shared

Deprecated

  • Locator(link: Link) is deprecated as it may create an incorrect Locator if the link type is missing.
    • Use publication.locate(Link) instead.

See Slack discussion for context: https://readium.slack.com/archives/C703MSTQU/p1642520174001200

Twin Kotlin PR: readium/kotlin-toolkit#83

@mickael-menu mickael-menu temporarily deployed to LCP April 27, 2022 16:37 Inactive
@mickael-menu mickael-menu temporarily deployed to LCP April 27, 2022 16:50 Inactive
@mickael-menu mickael-menu temporarily deployed to LCP May 10, 2022 10:16 Inactive
@mickael-menu mickael-menu merged commit 3474cad into develop May 10, 2022
@mickael-menu mickael-menu deleted the fix/link-to-locator branch May 10, 2022 10:29
mickael-menu added a commit that referenced this pull request May 10, 2022
@mickael-menu
Deprecate Locator(link: Link) in favor of Publication.locate(Link) (
99d15e3 
#47)
mickael-menu added a commit to demarque/readium-swift-toolkit that referenced this pull request May 18, 2022
@mickael-menu
Squashed commit of the following:
3ef3820 
commit 43580fc
Author: Mickaël Menu <mickael.menu@gmail.com>
Date:   Wed May 18 15:58:11 2022 +0200

    Add `TTSEngine.voiceWithIdentifier()`

commit d9d27b7
Merge: 2e5fbd1 1946257
Author: Mickaël Menu <mickael.menu@gmail.com>
Date:   Mon May 16 16:27:02 2022 +0200

    Merge branch 'develop' into feature/tts

commit 2e5fbd1
Author: Mickaël Menu <mickael.menu@gmail.com>
Date:   Wed May 11 13:27:18 2022 +0200

    Fix setting voice and language

commit 6d85d81
Author: Mickaël Menu <mickael.menu@gmail.com>
Date:   Wed May 11 11:27:46 2022 +0200

    Change the TTS voice

commit 6fdc0a5
Author: Mickaël Menu <mickael.menu@gmail.com>
Date:   Wed May 11 10:19:01 2022 +0200

    Refactor TTS engine and add `Language`

commit 15b9546
Author: Mickaël Menu <mickael.menu@gmail.com>
Date:   Tue May 10 14:46:04 2022 +0200

    Go to currently playing word

commit 230e577
Merge: 9ae1b7d 3474cad
Author: Mickaël Menu <mickael.menu@gmail.com>
Date:   Tue May 10 12:32:20 2022 +0200

    Merge branch 'develop' into feature/tts

commit 3474cad
Author: Mickaël Menu <mickael.menu@gmail.com>
Date:   Tue May 10 12:29:24 2022 +0200

    Deprecate `Locator(link: Link)` in favor of `Publication.locate(Link)` (readium#47)

commit 9ae1b7d
Author: Mickaël Menu <mickael.menu@gmail.com>
Date:   Mon May 9 19:16:37 2022 +0200

    Add the `ContentTokenizer`

commit bfd06f7
Author: Mickaël Menu <mickael.menu@gmail.com>
Date:   Mon May 9 17:56:03 2022 +0200

    Refactor the text tokanizers into functions and introduce generic `Tokenizer`

commit 966b9c1
Author: Mickaël Menu <mickael.menu@gmail.com>
Date:   Mon May 9 16:45:37 2022 +0200

    Tokenize the TTS text spans

commit 53e7d1c
Author: Mickaël Menu <mickael.menu@gmail.com>
Date:   Mon May 9 15:43:52 2022 +0200

    Add various text tokenizers

commit bfc92a5
Author: Mickaël Menu <mickael.menu@gmail.com>
Date:   Mon May 9 12:32:50 2022 +0200

    Implement previous()

commit 1be7114
Author: Mickaël Menu <mickael.menu@gmail.com>
Date:   Thu May 5 19:04:18 2022 +0200

    Refactor `TTSController`

commit f14d613
Author: Mickaël Menu <mickael.menu@gmail.com>
Date:   Thu May 5 18:40:54 2022 +0200

    Extract a `TTSEngine` protocol from the `TTSController`

commit f346158
Author: Mickaël Menu <mickael.menu@gmail.com>
Date:   Thu May 5 12:08:11 2022 +0200

    Add the TTS settings

commit 0ff9ad2
Author: Mickaël Menu <mickael.menu@gmail.com>
Date:   Tue May 3 19:38:15 2022 +0200

    Improve `TTSController`, add the `TTSViewModel`

commit 9b047ec
Author: Mickaël Menu <mickael.menu@gmail.com>
Date:   Mon May 2 16:24:21 2022 +0200

    Add the `TTSController`

commit c5de09b
Author: Mickaël Menu <mickael.menu@gmail.com>
Date:   Mon May 2 11:46:50 2022 +0200

    Add findFirstVisibleElement() JS API

commit 6ed6a7e
Author: Mickaël Menu <mickael.menu@gmail.com>
Date:   Thu Apr 28 18:39:16 2022 +0200

    Add the `HTMLResourceContentIterator` and `ContentIterationService`

commit 08e88ec
Author: Mickaël Menu <mickael.menu@gmail.com>
Date:   Thu Apr 28 12:14:28 2022 +0200

    Simplify the ContentIterator by making it synchronous

commit 0cb62a2
Author: Mickaël Menu <mickael.menu@gmail.com>
Date:   Thu Apr 28 11:36:25 2022 +0200

    Add the `PublicationContentIterator`

commit d6d3dea
Author: Mickaël Menu <mickael.menu@gmail.com>
Date:   Wed Apr 27 18:50:19 2022 +0200

    Update Carthage project

commit 935a51c
Author: Mickaël Menu <mickael.menu@gmail.com>
Date:   Wed Apr 27 18:36:04 2022 +0200

    Update changelog

commit 6964075
Author: Mickaël Menu <mickael.menu@gmail.com>
Date:   Wed Apr 27 18:34:52 2022 +0200

    Add tests and deprecate `Locator(link: Link)`

commit 3ab1381
Author: Mickaël Menu <mickael.menu@gmail.com>
Date:   Wed Apr 27 18:06:27 2022 +0200

    Refactor the `LocatorService` implementations and add `locate(Link)`
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@mickael-menu