Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better User deletion #3182

Closed
ericholscher opened this issue Oct 23, 2017 · 7 comments
Closed

Better User deletion #3182

ericholscher opened this issue Oct 23, 2017 · 7 comments
Assignees

Comments

@ericholscher
Copy link
Member

@ericholscher ericholscher commented Oct 23, 2017

With #3175 we now have a way for users to mark themselves as wanting to be deleted, now we need to actually delete them. This could be done inline during delete, or as a batch job that runs after the web view returns.

We want to actually delete the User instance, but we need to confirm a couple things:

  • Projects that the user only owns are deleted. This is a M2m, so we need to either remove them if there are multiple users, or delete the project if they are the only owner, so we don't end up with orphaned projects.
@ericholscher
Copy link
Member Author

@ericholscher ericholscher commented Oct 23, 2017

@agjohnson Anything else you can think of that attach to users? Looking at the code I see:

  • FK: Comments - will be deleted
  • FK: Bookmarks - will be deleted
  • M2M: Oauth connections - Believe these might need to be manually deleted (same logic, if only person in Org, delete, otherwise remove user)

@ericholscher
Copy link
Member Author

@ericholscher ericholscher commented Oct 23, 2017

We should also add a guide entry or something that is Googleable, that shows how to do this (http://docs.readthedocs.io/en/latest/guides/index.html)

@agjohnson
Copy link
Contributor

@agjohnson agjohnson commented Oct 23, 2017

Projects is the big one. There probably isn't a good reason why oauth models shouldn't be cascading if they aren't already -- those are all single user relations, but might have to be m2m for some other reason.

@shacharoo
Copy link

@shacharoo shacharoo commented Oct 25, 2017

Hey there,
The currently implemented "delete" feature is misleading.
I wanted to change my username, but I saw that it's impossible, so i went on and deleted (my empty) account thinking that I'd be able to create a new one with a new username. Nowhere does it say that the account is only "disabled".
Now I can't re-register because my email is in use (because the account wasn't actually deleted), nor can I reactivate the account. Something needs to be done here 😄

And on a personal note, If someone could hack the DB a bit and reactivate my account in the meantime, it would be delightful 🙏 Is there a support email anywhere? Couldn't find it.

Thanks,
Shachar.

@safwanrahman
Copy link
Member

@safwanrahman safwanrahman commented Oct 25, 2017

Hey @shacharoo, Apologies for the problem you are facing. Can you open a new issue about your problem so that we can ask out Operation teams to change the email or do other necessary things for you?
In the meantime, I am hoping to create a patch ASAP that will cover your use case.

@shacharoo
Copy link

@shacharoo shacharoo commented Oct 25, 2017

Will do @safwanrahman, thanks!

Opened #3189 .

safwanrahman added a commit to safwanrahman/readthedocs.org that referenced this issue Oct 31, 2017
safwanrahman added a commit to safwanrahman/readthedocs.org that referenced this issue Oct 31, 2017
@agjohnson agjohnson closed this in 762d342 Dec 6, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
5 participants
@ericholscher @agjohnson @safwanrahman @shacharoo and others