Navigation Menu

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

git command fails but build doesn't fail #5033

Closed
humitos opened this issue Dec 24, 2018 · 1 comment
Closed

git command fails but build doesn't fail #5033

humitos opened this issue Dec 24, 2018 · 1 comment
Assignees
Labels
Accepted Accepted issue on our roadmap Bug A bug

Comments

@humitos
Copy link
Member

humitos commented Dec 24, 2018

Details

I noticed this while reporting #5032

Expected Result

Fail the build completely.

Actual Result

git command fails, but the build continues and passes. This means that the version built is invalid and we end up serving inconsistent docs.

captura de pantalla_2018-12-24_10-48-03

@humitos humitos added Bug A bug Accepted Accepted issue on our roadmap labels Dec 24, 2018
@humitos humitos added this to the Build error reporting milestone Dec 24, 2018
@stsewd
Copy link
Member

stsewd commented Dec 24, 2018

I saw this when svn was failing some weeks ago, we need to verify the exit code and raise the proper exception.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Accepted Accepted issue on our roadmap Bug A bug
Projects
None yet
Development

No branches or pull requests

2 participants