Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add CORS support on Azurite for docker compose #6724

Closed
humitos opened this issue Feb 28, 2020 · 0 comments · Fixed by #6784
Closed

Add CORS support on Azurite for docker compose #6724

humitos opened this issue Feb 28, 2020 · 0 comments · Fixed by #6784
Labels
Accepted Accepted issue on our roadmap Good First Issue Good for new contributors Sprintable Small enough to sprint on

Comments

@humitos
Copy link
Member

humitos commented Feb 28, 2020

Since #6709 we are pinning an Azurite image with seems it has support for CORS headers.

I've tried this already but CORS was not supported in Azurite at that time:

# pip install azure-cli
# AZURE_STORAGE_CONNECTION_STRING="UseDevelopmentStorage=true" az storage cors add --origins 'community.dev.readthedocs.io' --services 'b' --methods GET OPTIONS HEAD --allowed-headers '*'
location /devstoreaccount1 {
proxy_pass http://storage:10000$request_uri;
}

To fix this issue, we need

  • run a similar command on startup (maybe using the azure-cli container)
  • remove that nginx block
  • update Django settings to re-point static domain
  • maybe others

Reference: #6709 (comment)

@humitos humitos added Good First Issue Good for new contributors Sprintable Small enough to sprint on Accepted Accepted issue on our roadmap labels Feb 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Accepted Accepted issue on our roadmap Good First Issue Good for new contributors Sprintable Small enough to sprint on
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant