Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Document variables used to resolve project/version/domain #7607

Closed
humitos opened this issue Oct 27, 2020 · 1 comment
Closed

Document variables used to resolve project/version/domain #7607

humitos opened this issue Oct 27, 2020 · 1 comment
Labels
Accepted Accepted issue on our roadmap Needed: documentation Documentation is required

Comments

@humitos
Copy link
Member

humitos commented Oct 27, 2020

It would be good to document the variables that we are injecting in the request object in the Proxito middleware (and maybe in other places as well) so we avoid confusions in the future.

We have (at least) these ones:

  • host_project_slug
  • path_version_slug
  • path_project_slug
  • cname
  • subdomain
  • rtdheader
  • external_domain
  • etc

Reference: #7593 (comment)
@humitos humitos added Needed: documentation Documentation is required Accepted Accepted issue on our roadmap labels Oct 27, 2020
@stsewd
Copy link
Member

stsewd commented Mar 6, 2023

With the refactors around proxito, most of those variables don't exist anymore. The remaining ones are path_version_slug and path_project_slug.

@humitos humitos closed this as completed Aug 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Accepted Accepted issue on our roadmap Needed: documentation Documentation is required
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@humitos @stsewd