Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move CDN code to external abstraction #2091

Merged
merged 6 commits into from Jun 6, 2018
Merged

Move CDN code to external abstraction #2091

merged 6 commits into from Jun 6, 2018

Conversation

@agjohnson
Copy link
Contributor

@agjohnson agjohnson commented Mar 25, 2016

This adds a signal for listening as an external application, purging can be
performed on a project basis there.

agjohnson added 2 commits Mar 25, 2016
This adds a signal for listening as an external application, purging can be
performed on a project basis there.
@ericholscher
Copy link
Member

@ericholscher ericholscher commented Mar 25, 2016

This should remove the CDN code from inside RTD, as well.

@agjohnson
Copy link
Contributor Author

@agjohnson agjohnson commented Mar 25, 2016

Forgot that, updated.

@ericholscher
Copy link
Member

@ericholscher ericholscher commented Mar 25, 2016

Guessing this is blocked on deployment as well? Looks good otherwise.

@agjohnson
Copy link
Contributor Author

@agjohnson agjohnson commented Mar 25, 2016

It shouldn't on the community site at least, as there aren't any cdn users configured

@ericholscher
Copy link
Member

@ericholscher ericholscher commented Mar 26, 2016

Ah, True.

@ericholscher
Copy link
Member

@ericholscher ericholscher commented Mar 28, 2016

👍 on merging re: conversation above.

@berkerpeksag
Copy link
Member

@berkerpeksag berkerpeksag commented Jul 15, 2016

It seems like the 'maxcdn' entries in tox.ini and requirements/deploy.txt are not needed.

@agjohnson
Copy link
Contributor Author

@agjohnson agjohnson commented Jul 16, 2016

Need to get back to this and rebase, will need to double check that the pieces we need are in the extension + operations provisioning.

Marked as blocking for now

@agjohnson agjohnson self-assigned this Oct 4, 2016
@agjohnson
Copy link
Contributor Author

@agjohnson agjohnson commented Feb 27, 2017

This is now unblocked and should be cleaned up.

@ericholscher
Copy link
Member

@ericholscher ericholscher commented Mar 6, 2017

@agjohnson anything specifically that needs to be cleaned up? I don't believe we currently have an CDN users, so this would be a good time to get it merged.

@ericholscher
Copy link
Member

@ericholscher ericholscher commented Mar 31, 2017

@agjohnson I'd be +1 on merging this now since we don't have any current CDN users, and we can confirm it works on the next setup we do.

@humitos
Copy link
Member

@humitos humitos commented Mar 23, 2018

@agjohnson is there anything else we need to do here?

It seems that we remove the purge function and now it's triggering a signal, but the signal is not connected --so, the old purge function / code is not being executed.

@ericholscher ericholscher merged commit 3fc3c15 into master Jun 6, 2018
2 checks passed
@stsewd stsewd deleted the cdn-abstraction branch Aug 15, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants