Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pass query string when redirecting, fixes #2595 #3001

Closed
wants to merge 1 commit into from

Conversation

@andrew
Copy link

@andrew andrew commented Jul 13, 2017

Took a stab at fixing #2595, not worked with flask before but this seems to do the trick.

@ericholscher
Copy link
Member

@ericholscher ericholscher commented Jul 17, 2017

Looks great! I'll get it tested locally and then merged in :)

@ericholscher ericholscher self-assigned this Jul 17, 2017
@agjohnson
Copy link
Contributor

@agjohnson agjohnson commented Jul 27, 2017

This file should also be removed, as should probably most anything under deploy/, it's no longer used. The correct version is a private repository now.

@humitos
Copy link
Member

@humitos humitos commented Dec 5, 2017

The correct version is a private repository now.

Do we still need this fix in the private repo version or it was already fixed?

@ericholscher
Copy link
Member

@ericholscher ericholscher commented Dec 5, 2017

Nope. Still needs to be fixed :(

@humitos
Copy link
Member

@humitos humitos commented Dec 6, 2017

OK, I copied the patch to that private repository you pointed me. Closing this PR, there is nothing else to do here.

Thanks for your contribution!

@humitos humitos closed this Dec 6, 2017
@andrew
Copy link
Author

@andrew andrew commented Dec 6, 2017

My first ever python contribution 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants