Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't delete the subprojects directory on sync of superproject #3042

Merged
merged 4 commits into from Dec 7, 2017

Conversation

@ericholscher
Copy link
Member

@ericholscher ericholscher commented Aug 11, 2017

No description provided.

@ericholscher
Copy link
Member Author

@ericholscher ericholscher commented Oct 24, 2017

@agjohnson should get this merged, since I believe I already hotfixed it, or remove it.

@agjohnson
Copy link
Contributor

@agjohnson agjohnson commented Dec 4, 2017

Needs lint fix still. I believe we discussed this already, but I'm not certain this actually addressed the issue with subproject removal entirely. I think this at least does something though, so we should merge after the lint fixes.

@ericholscher ericholscher merged commit 6a18b75 into master Dec 7, 2017
2 checks passed
@RichardLitt RichardLitt deleted the exclude-projects branch Dec 7, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants