Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replaced usage of deprecated function get_fields_with_model with new … #3052

Merged
merged 4 commits into from Dec 5, 2017

Conversation

@josejrobles
Copy link
Contributor

@josejrobles josejrobles commented Aug 17, 2017

Replaced usage of deprecated function get_fields_with_model with new local function, which does the same thing.

Copy link
Contributor

@agjohnson agjohnson left a comment

I don't quite follow why the fix is required. It would be to comment some of this in the code. Otherwise, this looks good to me!

@@ -28,6 +28,15 @@
from builtins import range


def get_fields_with_model(cls):
return [
Copy link
Contributor

@agjohnson agjohnson Aug 17, 2017

If this is a prescribed Django fix for this, perhaps link to the permalink in docs here to explain what this is for.

Copy link
Member

@humitos humitos left a comment

I'm OK with this change.

Is there something missing before merging?

@RichardLitt
Copy link
Member

@RichardLitt RichardLitt commented Nov 27, 2017

I don't think so. @agjohnson review again?

@agjohnson
Copy link
Contributor

@agjohnson agjohnson commented Dec 5, 2017

Thanks for the @josejrobles, looks good to me! 🎉

@agjohnson agjohnson merged commit 4b01021 into readthedocs:master Dec 5, 2017
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants