Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change stable version switching to respect active #3336

Merged
merged 2 commits into from Nov 30, 2017

Conversation

@ericholscher
Copy link
Member

@ericholscher ericholscher commented Nov 30, 2017

This previously used the machine tag that was turned off when a user de-activated the version,
but never turned back on when they re-activated it.

This changes to just use the active flag on the Version,
so we will update the stable version if the existing one is active,
and not if it isn't,
which makes way more sense.

Refs #3268

This previously used the `machine` tag that was turned off when a user de-activated the version,
but never turned back on when they re-activated it.

This changes to just use the `active` flag on the Version,
so we will update the stable version if the existing one is `active`,
and not if it isn't,
which makes _way_ more sense.
@ericholscher
Copy link
Member Author

@ericholscher ericholscher commented Nov 30, 2017

I think we should probably just kill the whole machine concept, unless we see value in it going forward?

@ericholscher ericholscher requested review from humitos and agjohnson Nov 30, 2017
@ericholscher ericholscher force-pushed the use-active-for-stable branch from c71b635 to 01abd43 Nov 30, 2017
@ericholscher ericholscher merged commit 0d9c3fe into master Nov 30, 2017
2 checks passed
ericholscher added a commit that referenced this issue Dec 6, 2017
This reverts commit 0d9c3fe, reversing
changes made to 73b693c.
ericholscher added a commit that referenced this issue Dec 6, 2017
This reverts commit 0d9c3fe, reversing
changes made to 73b693c.
agjohnson added a commit that referenced this issue Dec 6, 2017
ericholscher added a commit that referenced this issue Dec 7, 2017
Revert "Merge pull request #3336 from rtfd/use-active-for-stable"
@stsewd stsewd deleted the use-active-for-stable branch Aug 15, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants