Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add note about mercurial on tests #3358

Merged
merged 4 commits into from Dec 8, 2017

Conversation

@stsewd
Copy link
Member

@stsewd stsewd commented Dec 5, 2017

I just add a note about mercurial to solve #3320.

humitos
humitos approved these changes Dec 5, 2017
Copy link
Member

@humitos humitos left a comment

Nice!

@agjohnson
Copy link
Contributor

@agjohnson agjohnson commented Dec 5, 2017

Thanks for the update @stsewd !

@agjohnson
Copy link
Contributor

@agjohnson agjohnson commented Dec 5, 2017

Actually, if we are already requiring this for tests, perhaps we just install mercurial in our testing requirements? @stsewd would you maybe want to change this PR to just install via requirements/testing.txt instead?

@stsewd
Copy link
Member Author

@stsewd stsewd commented Dec 5, 2017

Sure, that's better (I didn't know mercurial was written in python D:).

@stsewd
Copy link
Member Author

@stsewd stsewd commented Dec 6, 2017

@agjohnson Is it okay if the Mercurial version is not specified?
And can I squash the commits later or it's fine like that?

@agjohnson
Copy link
Contributor

@agjohnson agjohnson commented Dec 7, 2017

Normally, it would be fine -- we've been pinning our testing dependencies lately because they break in CI so often though. Pinning to the latest release should be fine

@stsewd stsewd force-pushed the add-note-about-mercurial branch from 41e02cf to eca1c5a Dec 8, 2017
@stsewd
Copy link
Member Author

@stsewd stsewd commented Dec 8, 2017

@agjohnson Ready, I set the version to the latest (4.4.2)

@ericholscher
Copy link
Member

@ericholscher ericholscher commented Dec 8, 2017

Looks great, thanks!

@ericholscher ericholscher merged commit 3e55344 into readthedocs:master Dec 8, 2017
1 check passed
@stsewd stsewd deleted the add-note-about-mercurial branch Feb 27, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants