Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't display the build suggestions div if there are no suggestions #3389

Merged
merged 1 commit into from Dec 14, 2017

Conversation

@agjohnson
Copy link
Contributor

@agjohnson agjohnson commented Dec 8, 2017

This added extraneous spacing to the build page.

@agjohnson agjohnson requested a review from ericholscher Dec 8, 2017
<p>
{% url 'projects_advanced' build.version.project.slug as advanced_url %}
{% blocktrans %}
Don't want <pre>setup.py install</pre> called?
Copy link
Member

@humitos humitos Dec 11, 2017

This tag was changed to em

Copy link
Member

@ericholscher ericholscher left a comment

What manuel said, needs the em. Otherwise looks good.

This added extraneous spacing to the build page.
@agjohnson agjohnson force-pushed the agj/remove-empty-build-idea branch from ac6c81d to f028e2e Dec 14, 2017
@agjohnson
Copy link
Contributor Author

@agjohnson agjohnson commented Dec 14, 2017

Rebased.

@agjohnson
Copy link
Contributor Author

@agjohnson agjohnson commented Dec 14, 2017

Error is fixed in #3402

@agjohnson agjohnson merged commit 2bdc987 into master Dec 14, 2017
0 of 2 checks passed
@agjohnson agjohnson deleted the agj/remove-empty-build-idea branch Dec 14, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants