Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove copyright application #3400

Merged
merged 1 commit into from Dec 14, 2017

Conversation

@stsewd
Copy link
Member

@stsewd stsewd commented Dec 14, 2017

This PR closes #3199

@stsewd
Copy link
Member Author

@stsewd stsewd commented Dec 14, 2017

Travis is falling for the same reason on master

https://github.com/rtfd/readthedocs.org/blob/1a053bdf358b29494a81055885029cfb7c60bf43/readthedocs/restapi/views/footer_views.py#L46

There is any PR on the way to solve this? So I can rebase.

Loading

@agjohnson
Copy link
Contributor

@agjohnson agjohnson commented Dec 14, 2017

Oops, yeah looks like an PR wasn't wrapped up completely. I just submitted #3402 to address the lint error. Feel free to cherry-pick or rebase there.

Loading

Copy link
Contributor

@agjohnson agjohnson left a comment

This looks great! I think we can just merge this and when #3402 is merged, the lint error will be resolved.

Loading

@agjohnson agjohnson merged commit 4373cba into readthedocs:master Dec 14, 2017
1 check failed
Loading
@stsewd stsewd deleted the remove-copyright-application branch Dec 14, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

2 participants