Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Link to version detail page from build detail page #3418

Merged
merged 1 commit into from Dec 21, 2017

Conversation

@humitos
Copy link
Member

@humitos humitos commented Dec 18, 2017

On a build detail page, link the version detail page that it's being built if the user is the admin of the project, otherwise just show the slug as usual.

Related to #3417

@@ -62,7 +63,11 @@

<div class="build-version">
<span class="build-version-slug">
{{ build.version.slug }}
{% if request.user|is_admin:project %}
<a href="{% url "project_version_detail" build.version.project.slug build.version.slug %}">{{ build.version.slug }}</a>
Copy link
Member

@ericholscher ericholscher Dec 18, 2017

This should probably add an "Edit this version" link, not just link the actual version name.

Copy link
Member Author

@humitos humitos Dec 19, 2017

Yeah, I didn't know where/how to put to not break the style since the commit hash is already between parenthesis (and I like that) so, I was thinking on adding the "Edit this version" in the following line. What do you think?

Copy link
Member Author

@humitos humitos Dec 19, 2017

Example

0.14.4 (acbd8asd67a8761asvsd)
Edit this version

Copy link
Contributor

@agjohnson agjohnson Dec 19, 2017

I'd prefer the text link actually. "Edit this version" is a verbose addition. I think working a button into the interface is adding another design pattern to track. I'd rather revisit this when we have a better idea of what design patterns we're using on these interfaces.

@humitos humitos force-pushed the humitos/build/link-version-detail branch from 508a7f0 to b3274fb Dec 20, 2017
@humitos
Copy link
Member Author

@humitos humitos commented Dec 20, 2017

Marking this as blocked since we need to define the UI pattern for this first.

@ericholscher
Copy link
Member

@ericholscher ericholscher commented Dec 20, 2017

I think we should just merge it as is, and open another ticket for it. No reason to block this.

@ericholscher ericholscher merged commit 26102e0 into master Dec 21, 2017
1 check passed
@agjohnson agjohnson deleted the humitos/build/link-version-detail branch Dec 24, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants