Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use default avatar for User/Orgs in OAuth services #3419

Merged
merged 2 commits into from Dec 18, 2017

Conversation

@humitos
Copy link
Member

@humitos humitos commented Dec 18, 2017

Example:

captura de pantalla_2017-12-18_15-01-06

Closes #3353

@humitos humitos requested review from ericholscher and agjohnson Dec 18, 2017
@ericholscher ericholscher merged commit 3cfba49 into master Dec 18, 2017
0 of 2 checks passed
@agjohnson agjohnson deleted the humitos/oauth/default-avatar branch Dec 20, 2017
@jlumbroso
Copy link

@jlumbroso jlumbroso commented Jul 26, 2020

@agjohnson @humitos @ericholscher I am wondering what is the current state of avatars on readthedocs?

For instance, as a maintainer of the comma project, my avatar is the default blank:

Screen Shot 2020-07-26 at 12 33 24 PM

I have connected my GitHub account to my RTD.io account, and it contains an avatar. I have also looked through all the settings dialogs to see whether I could upload my own avatar. On the other hand, I have noticed many others have an avatar (this project for instance), and I am not sure what they are doing differently—or this is a bug.

@stsewd
Copy link
Member

@stsewd stsewd commented Jul 26, 2020

@jlumbroso this github avatar is only shown in the import list, for the avatar itself we use the one from gravatar (probably we should document this)

@jlumbroso
Copy link

@jlumbroso jlumbroso commented Jul 26, 2020

@stsewd Many many thanks for the super speedy response! That's exactly what I needed to know!

In terms of documentation, I would suggest simply adding a mention in the "Profile" editing section, saying

Avatars are sourced from Gravatar using your Primary Verified email address. To configure your avatar register an account on Gravatar with the proper email address.

Screen Shot 2020-07-26 at 12 44 25 PM copy

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

4 participants