Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add celery theme to supported ad options #3425

Merged
merged 1 commit into from Dec 21, 2017
Merged

Conversation

@ericholscher
Copy link
Member

@ericholscher ericholscher commented Dec 19, 2017

No description provided.

Copy link
Member

@humitos humitos left a comment

LGTM!

Question, why do we need those two new fonts?

and, readthedocs-doc-embed.js it's an autogenerated file that includes the new changes to the sponsorship.js? So, instead of dowloading a couple of files from one page, just download one, the -embed.js?

@ericholscher
Copy link
Member Author

@ericholscher ericholscher commented Dec 20, 2017

The fonts were just autoincluded when I ran grunt. Yea we have one file thats run on doc pages.

@ericholscher ericholscher merged commit 7004cf0 into master Dec 21, 2017
2 checks passed
@agjohnson agjohnson deleted the celery-sponsorship branch Dec 24, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants