Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check to make sure changes exist in BitBucket pushes #3480

Merged
merged 3 commits into from Jan 15, 2018

Conversation

@ericholscher
Copy link
Member

@ericholscher ericholscher commented Jan 5, 2018

No description provided.

@ericholscher ericholscher requested review from agjohnson and humitos Jan 5, 2018
Copy link
Member

@humitos humitos left a comment

This PR seems like we are "protecting us from something weird that Bitbucket does". I mean, why would Bitbucket send us a webhook when nothing has changed?

Otherwise it looks good to me.

Py3 test are not passing for an unrelated thing. I restarted the job.

@ericholscher
Copy link
Member Author

@ericholscher ericholscher commented Jan 5, 2018

It has happened a few thousand times, so I'm guessing it's just part of the normal flow, perhaps on actions other than commits they are sending the hook?

@humitos
Copy link
Member

@humitos humitos commented Jan 5, 2018

Maybe we have missconfigurated the events we subscribed to?

@ericholscher
Copy link
Member Author

@ericholscher ericholscher commented Jan 5, 2018

People can also change this themselves, so it doesn't really matter in the end. We need to support misformed data here.

@humitos
Copy link
Member

@humitos humitos commented Jan 5, 2018

You are right.

@agjohnson agjohnson merged commit bb3deae into master Jan 15, 2018
1 check passed
@agjohnson agjohnson deleted the cleanup-bitbucket-data branch Jan 15, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants