Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use relative path for docroot on mkdocs #3525

Merged
merged 5 commits into from Oct 2, 2018

Conversation

@stsewd
Copy link
Member

@stsewd stsewd commented Jan 17, 2018

While replicating #3515, I noticed that the other "edit" link (at the float version menu) was wrong #3515 (comment)

Fixes #1917

@stsewd stsewd mentioned this pull request Jan 17, 2018
@stsewd
Copy link
Member Author

@stsewd stsewd commented Jan 18, 2018

Due to #3497, with this change the first build fails, probably we want to solve that issue before merging.

@marcelstoer
Copy link
Contributor

@marcelstoer marcelstoer commented Jan 21, 2018

@RichardLitt maybe add the Mkdocs label as well?

@agjohnson agjohnson added this to the Mkdocs milestone Apr 10, 2018
@agjohnson agjohnson removed the Mkdocs label Apr 10, 2018
@stsewd stsewd force-pushed the fix-docroot-path-mkdocks branch from 2649b90 to 537fb3f Jun 6, 2018
@stsewd
Copy link
Member Author

@stsewd stsewd commented Jun 6, 2018

The origaal blocking issue #3525 (comment) can't be replicated, so it's safe to continue, I only need to add a test, but I started some tests for mkdocs in #4184, so I would like to merge that PR first.

@stsewd stsewd force-pushed the fix-docroot-path-mkdocks branch from 537fb3f to 8bf99fc Jun 7, 2018
docs_path = os.path.join(self.root_path, docs_dir)
# The docs path is relative to the location
# of the mkdocs configuration file.
docs_path = os.path.join(
Copy link
Member Author

@stsewd stsewd Jun 7, 2018

humitos
humitos approved these changes Jun 8, 2018
Copy link
Member

@humitos humitos left a comment

Looks good 👍

@humitos
Copy link
Member

@humitos humitos commented Oct 1, 2018

@stsewd Is it needed something else here to merge this PR? If no, feel free to merge.

@stsewd
Copy link
Member Author

@stsewd stsewd commented Oct 1, 2018

We are good here, I'll do a last rebase to see if we don't need changes after the PR for mkdocs that was merged recently. Also, probably after tests on master pass.

@stsewd stsewd force-pushed the fix-docroot-path-mkdocks branch from 8eeb728 to 60c31e7 Oct 1, 2018
@stsewd
Copy link
Member Author

@stsewd stsewd commented Oct 2, 2018

We are all green again

@stsewd stsewd merged commit 5ffb6bc into readthedocs:master Oct 2, 2018
1 check passed
@stsewd stsewd deleted the fix-docroot-path-mkdocks branch Oct 2, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

5 participants