Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade requests version #3557

Merged
merged 1 commit into from Feb 6, 2018
Merged

Conversation

@davidfischer
Copy link
Contributor

@davidfischer davidfischer commented Jan 26, 2018

This is related to a production issue with the older requests version.

@humitos
Copy link
Member

@humitos humitos commented Jan 26, 2018

Be careful with requests upgrade since it's not fully compatible with all versions of docker-py: #3243 (comment)

Loading

@davidfischer
Copy link
Contributor Author

@davidfischer davidfischer commented Jan 26, 2018

If anything, we want to upgrade further. docker/docker-py@3b95da3

Loading

@humitos
Copy link
Member

@humitos humitos commented Jan 26, 2018

I agree. I'd like to upgrade docker and requests to the latest version available. We need to consider that RTD servers will be using 17.05.0~ce-0~ubuntu-xenial which is also not the latest docker engine. So, we need to be carefull that these three dependencies work all together :)

Ref: readthedocs/readthedocs-ops#233

Loading

@ericholscher
Copy link
Member

@ericholscher ericholscher commented Jan 30, 2018

Do we know if these are safe? Did we hotfix prod for the issue the other day with this version? @agjohnson

Loading

@agjohnson
Copy link
Contributor

@agjohnson agjohnson commented Jan 30, 2018

I used 2.9.1 (system version) as the first version that wasn't reproducing the error. I don't see a reason to not go higher though. I didn't test this at all though

Loading

@agjohnson agjohnson merged commit 31043bd into readthedocs:master Feb 6, 2018
1 check passed
Loading
@agjohnson
Copy link
Contributor

@agjohnson agjohnson commented Feb 6, 2018

This is needed. Higher bump can be done later.

Loading

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants