Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Analytics fixes #3558

Merged
merged 1 commit into from Jan 30, 2018
Merged

Conversation

@davidfischer
Copy link
Contributor

@davidfischer davidfischer commented Jan 27, 2018

  • the analytics ID wasn't coming thru to GA correctly
  • the click handler was only working for image clicks not ad text clicks
- the analytics ID wasn't coming thru to GA correctly
- the click handler was only working for image clicks
  not ad text clicks
@@ -81,7 +81,7 @@ Promo.prototype.place_promo = function (selector, promo_class) {
.attr('class', 'rtd-pro-image-wrapper')
.attr('href', self.link)
.attr('target', '_blank')
.on('click', this.click_handler);
.on('click', self.click_handler);
Copy link
Contributor Author

@davidfischer davidfischer Jan 27, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This actually wasn't strictly a problem. It is more clear though.

Loading

@@ -97,7 +97,7 @@ Promo.prototype.place_promo = function (selector, promo_class) {
.attr('class', 'rtd-pro-link')
.attr('href', self.link)
.attr('target', '_blank')
.on('click', this.click_handler);
.on('click', self.click_handler);
Copy link
Contributor Author

@davidfischer davidfischer Jan 27, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was a scoping problem as this in this context is DOM <a> element.

Loading

@ericholscher ericholscher merged commit b30b6d0 into readthedocs:master Jan 30, 2018
1 check passed
Loading
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants