Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Git on prod #3615

Merged
merged 1 commit into from May 24, 2018
Merged

Update Git on prod #3615

merged 1 commit into from May 24, 2018

Conversation

@techtonik
Copy link
Contributor

@techtonik techtonik commented Feb 15, 2018

This is required to fix Edit button on annotated tags
#3441 (reverted fix)

This is required to fix Edit button on annotated tags
readthedocs#3441 (reverted fix)
@techtonik techtonik mentioned this pull request Feb 15, 2018
@ericholscher
Copy link
Member

@ericholscher ericholscher commented Feb 16, 2018

I wish this is as easy as it was to update git in our production instances. Our builders are currently running 14.04, so "update git in prod" actually means "fully re-deploy an entire stack of servers". We're going to be transitioning away from Rackspace soon, so that upgrade will take place as part of our server migrations.

@techtonik
Copy link
Contributor Author

@techtonik techtonik commented Feb 16, 2018

@ericholscher from https://docs.readthedocs.io/en/latest/development/buildenvironments.html it looks like those builders are Docker images, so changing them to 16.04 should be easy.

@ericholscher
Copy link
Member

@ericholscher ericholscher commented Feb 18, 2018

Git is currently run outside of docker in some cases, for reasons :)

@techtonik
Copy link
Contributor Author

@techtonik techtonik commented Feb 18, 2018

@ericholscher are there any security reasons to keep the workflow undocumented? =)

@ericholscher
Copy link
Member

@ericholscher ericholscher commented Feb 18, 2018

Just lack of time.

Copy link
Member

@humitos humitos left a comment

Thanks!

I think we can merge this already.

Servers where upgraded to 16.04 and they are running git 2.7.4 at the moment.

@stsewd
Copy link
Member

@stsewd stsewd commented May 2, 2018

I'm fixing the edit button problem using gitpython on #4052

@ericholscher
Copy link
Member

@ericholscher ericholscher commented May 24, 2018

Will go ahead and merge this, as I believe our git is upgraded in production.

@ericholscher ericholscher merged commit 480c367 into readthedocs:master May 24, 2018
1 check passed
@techtonik techtonik deleted the patch-3 branch Sep 20, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

5 participants