Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Anonymize IP addresses for Google Analytics #3626

Merged
merged 1 commit into from Feb 18, 2018

Conversation

@davidfischer
Copy link
Contributor

@davidfischer davidfischer commented Feb 16, 2018

For RTD's analytics purposes, we never need IP addresses more granular than this.

https://support.google.com/analytics/answer/2763052?hl=en

@davidfischer
Copy link
Contributor Author

@davidfischer davidfischer commented Feb 16, 2018

In fact if anything, we could further anonymize the data but I don't think that's supported.

@ericholscher
Copy link
Member

@ericholscher ericholscher commented Feb 18, 2018

💯

@ericholscher
Copy link
Member

@ericholscher ericholscher commented Feb 18, 2018

Thanks for looking into this!

@ericholscher ericholscher merged commit fb36498 into readthedocs:master Feb 18, 2018
1 check passed
@seibert
Copy link

@seibert seibert commented Mar 20, 2018

Is there an ETA for when this will be rolled out to the website?

@stsewd
Copy link
Member

@stsewd stsewd commented Mar 20, 2018

@seibert it's deployed right now :)

@davidfischer
Copy link
Contributor Author

@davidfischer davidfischer commented Mar 20, 2018

This is out and live for readthedocs.org and has been for a month or so. If you have an analytics debugger, you can verify this as in the below screenshot.

screen shot 2018-03-20 at 2 29 21 pm

However, individual docs sites need to be built again after this change and the relevant theme change readthedocs/readthedocs-sphinx-ext#37 was pushed to production and they have to take the updated theme. So depending on when and how the documentation you are browsing was built, it may not have taken effect yet. This is currently a limitation of our analytics that they are part of the documentation build process rather than a JS file we link to that can be updated independently of a build. It's on my list to change.

@davidfischer
Copy link
Contributor Author

@davidfischer davidfischer commented Apr 5, 2018

I wanted to give a small update here. All docs built from ~12 hours ago on will use this setting.

I mispoke when I talked about "theme". Instead we simply needed to push our Read the Docs sphinx extensions to PyPI which happened yesterday.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants