Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove error logging that isn't an error. #3650

Merged
merged 1 commit into from Feb 23, 2018
Merged

Conversation

@ericholscher
Copy link
Member

@ericholscher ericholscher commented Feb 22, 2018

This is clogging up our Sentry instance,
causing us to go over our free allotment.

This is clogging up our Sentry instance,
causing us to go over our free allotment.
Copy link
Contributor

@davidfischer davidfischer left a comment

👍

Loading

@@ -148,7 +148,7 @@ def commit_name(self):

# If we came that far it's not a special version nor a branch or tag.
# Therefore just return the identifier to make a safe guess.
log.error('TODO: Raise an exception here. Testing what cases it happens')
log.debug('TODO: Raise an exception here. Testing what cases it happens')
Copy link
Member

@humitos humitos Feb 22, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ups! I introduced this for future research and I never did it :/

Loading

@ericholscher ericholscher merged commit 0a4a287 into master Feb 23, 2018
1 check passed
Loading
@stsewd stsewd deleted the remove-error-logs branch Aug 15, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants