Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade django-pagination to a "maintained" fork #3666

Merged
merged 2 commits into from Mar 13, 2018

Conversation

@humitos
Copy link
Member

@humitos humitos commented Feb 23, 2018

Closes #3664

The package django-pagination got unmaintained, so a fork by Linaro
was created at https://github.com/zyga/django-pagination and got
unmaintained again (zyga/django-pagination#42).

Now, there is another fork at https://github.com/pydanny/dj-pagination)
that contains more compatibility releases. So, I'm upgrading to this one.

Closes #3664

The package `django-pagination` got unmaintained, so a fork by Linaro
was created at https://github.com/zyga/django-pagination and got
unmaintained again (zyga/django-pagination#42).

Now, there is another fork at https://github.com/pydanny/dj-pagination)
that contains more compatibility releases. So, I'm upgrading to this one.
@ericholscher
Copy link
Member

@ericholscher ericholscher commented Feb 26, 2018

What method of testing was used here to confirm it doesn't break on the actual site?

@humitos
Copy link
Member Author

@humitos humitos commented Mar 6, 2018

@ericholscher all the test are passing without problem and I also tested this manually by hitting all the pages where autopaginate is used in the template:

  • build list
  • bookmark list (not used --app to be removed)
  • project list

I wasn't able to test it in (I don't have elasticsearch configured)

  • search page /projects/search.html
  • faceted page /search/faceted_results.html

Let me know if you consider that it's enough.

@ericholscher
Copy link
Member

@ericholscher ericholscher commented Mar 6, 2018

That should be fine. I just wanted to make sure it was tested in a running instance, and not just the unit tests.

@humitos
Copy link
Member Author

@humitos humitos commented Mar 13, 2018

@ericholscher can we merge this one?

@humitos humitos requested a review from agjohnson Mar 13, 2018
@ericholscher
Copy link
Member

@ericholscher ericholscher commented Mar 13, 2018

👍 -- let's wait til tomorrow, but then merge~!

@humitos humitos merged commit 3306d3a into master Mar 13, 2018
1 check passed
@humitos humitos deleted the humitos/django-pagination/upgrade branch Mar 13, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants