Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade django-taggit to 0.22.2 #3667

Merged
merged 1 commit into from Feb 27, 2018
Merged

Upgrade django-taggit to 0.22.2 #3667

merged 1 commit into from Feb 27, 2018

Conversation

@humitos
Copy link
Member

@humitos humitos commented Feb 23, 2018

Upgrade this package to be more prepared for Python3 and Django 2.0

Related #3666

Upgrade this package to be more prepared for Python3 and Django 2.0
@ericholscher
Copy link
Member

@ericholscher ericholscher commented Feb 26, 2018

Does this work in dev?

Copy link
Contributor

@davidfischer davidfischer left a comment

LGTM.

This is working for me in dev, @ericholscher.

It is unclear why we switched from a released taggit version to version directly from git, but it based on #843 it appears it was done before Django 1.6. Based on taggit's Changelog the changes appear minor and around compatibility. There are no new migrations.

@agjohnson agjohnson merged commit 09f8282 into master Feb 27, 2018
1 check passed
@agjohnson agjohnson deleted the humitos/django-taggit/upgrade branch Feb 27, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants