Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ticket #3694: rename owners to maintainers #3703

Merged
merged 1 commit into from May 24, 2018
Merged

Ticket #3694: rename owners to maintainers #3703

merged 1 commit into from May 24, 2018

Conversation

@ajatprabha
Copy link
Contributor

@ajatprabha ajatprabha commented Mar 1, 2018

patches #3694: renamed owners to maintainers, until a differentiation is established between an owner and a maintainer at model level.

Copy link
Member

@humitos humitos left a comment

Thanks for your contribution.

Left a note to ourselves for the corporate site.

@@ -33,8 +33,8 @@ <h3>{% trans "Last Built" %}</h3>
</p>
{% endblock %}

{% block owners %}
<h3>{% trans "Owners" %}</h3>
{% block maintainers %}
Copy link
Member

@humitos humitos Mar 23, 2018

In case we change the block name, we will need to update our template in the corporate site:

readthedocsinc/corporate/templates/core/project_detail_right.html

stsewd
stsewd approved these changes May 1, 2018
Copy link
Member

@stsewd stsewd left a comment

LGTM

@ericholscher ericholscher merged commit 8175974 into readthedocs:master May 24, 2018
1 check passed
@ericholscher
Copy link
Member

@ericholscher ericholscher commented May 24, 2018

I changed the block name after commit. 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

5 participants