Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix tests for Git submodule #3737

Merged
merged 1 commit into from Mar 6, 2018
Merged

Fix tests for Git submodule #3737

merged 1 commit into from Mar 6, 2018

Conversation

@agjohnson
Copy link
Contributor

@agjohnson agjohnson commented Mar 5, 2018

I can't explain why this isn't happening for everyone, however the issue I git
was that my global git config wasn't being picked up. This explicitly sets the
user name and email to avoid erroring out on the following calls.

I can't explain why this isn't happening for everyone, however the issue I git
was that my global git config wasn't being picked up. This explicitly sets the
user name and email to avoid erroring out on the following calls.
@agjohnson agjohnson requested a review from Mar 5, 2018
Copy link
Contributor

@davidfischer davidfischer left a comment

This wasn't necessary for me so there must be something with your setup. However, better to be explicit.

Loading

humitos
humitos approved these changes Mar 6, 2018
Copy link
Member

@humitos humitos left a comment

I didn't have this problem in my local setup either.

I remember that I had this problem when I was working with the VCS code and this was exactly the problem: wrong GIT_DIR environment variable.

This isn't dangerous as it is, but a small change will end up changing the global git defaults in the under the current user.

As David said, I suppose that it's better explicit here. So, we are good.

(I tested this locally by running all the py36 tests and did work)

Loading

@agjohnson agjohnson merged commit e25acfa into master Mar 6, 2018
1 check passed
Loading
@agjohnson agjohnson deleted the agj/fix-test-submodule branch Mar 6, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants