Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#3741: replaced Go Crazy text with Search #3752

Merged
merged 2 commits into from Mar 7, 2018
Merged

#3741: replaced Go Crazy text with Search #3752

merged 2 commits into from Mar 7, 2018

Conversation

@rajujha373
Copy link
Contributor

@rajujha373 rajujha373 commented Mar 7, 2018

No description provided.

@@ -24,7 +24,7 @@
<input type="hidden" name="selected_facets" value="{{ selected_facets }}" id='id_selected_facets'>
</div>
<div class="submit-input-wrapper">
<input type="submit" value="{% trans "Go crazy." %}" id="id_search_button">
<input type="submit" value='{% trans "Search" %}' id="id_search_button">
Copy link
Member

@stsewd stsewd Mar 7, 2018

You shouldn't change the double quotes to single quotes here, html needs ".

Copy link
Contributor Author

@rajujha373 rajujha373 Mar 7, 2018

"{% trans 'search' %}"
This syntax will do i guess. I think both shall not be double quotes.. Do correct me if i'm wrong

@@ -14,7 +14,7 @@
</div>
<div class="submit-input-wrapper">
{% comment %}Translators: This is about starting a search{% endcomment %}
<input type="submit" value="{% trans "Go crazy." %}">
<input type="submit" value='{% trans "Search" %}'
Copy link
Member

@stsewd stsewd Mar 7, 2018

I think you removed the > accidentally here

Copy link
Contributor Author

@rajujha373 rajujha373 Mar 7, 2018

oops.. my bad :D I'll correct it for sure :)

Copy link
Member

@RichardLitt RichardLitt left a comment

This makes a ton of sense to me. Crazy is an offensive word in some circles, as it is an ableist word.

@agjohnson
Copy link
Contributor

@agjohnson agjohnson commented Mar 7, 2018

I'm glad someone was able jump in and clean this up, thanks for the contribution @rajujha373 ! 🎉

@agjohnson agjohnson merged commit 4d4b128 into readthedocs:master Mar 7, 2018
1 check passed
@rajujha373
Copy link
Contributor Author

@rajujha373 rajujha373 commented Mar 8, 2018

@agjohnson and @RichardLitt thank you so much guys ... This is my first merged changes in readthedocs... Yayy 🥇 🎉

@RichardLitt
Copy link
Member

@RichardLitt RichardLitt commented Mar 8, 2018

Well done, @rajujha373! Welcome to the family. Make yourself at home. :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants