Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added eslint rules #3768

Merged
merged 1 commit into from Mar 14, 2018
Merged

Added eslint rules #3768

merged 1 commit into from Mar 14, 2018

Conversation

@bansalnitish
Copy link
Contributor

@bansalnitish bansalnitish commented Mar 11, 2018

This PR adds the following lint rules :

  • semi
  • space-unary-ops
  • space-before-function-paren
  • no-unused-vars

I have removed the errors that were present in the code. Now we get 51 warnings and 0 errors. Except no-unused-var all are set to error.

indent rule is left to be added. I will make a separate PR just for indent as there are large no. of errors (more than 600) associated with adding this rule.

@bansalnitish bansalnitish changed the title Added lint rules Added eslint rules Mar 11, 2018
Copy link
Contributor

@davidfischer davidfischer left a comment

Nice. I'm looking forward to having this in master. I'll know @agjohnson is always interested in JS changes so I'll leave this for a day or so for him to look at before merging.

@bansalnitish
Copy link
Contributor Author

@bansalnitish bansalnitish commented Mar 12, 2018

Thanks @davidfischer

@davidfischer
Copy link
Contributor

@davidfischer davidfischer commented Mar 13, 2018

I merged master into this branch and may have created a minor disaster in the commit stream. However, I believe this is merge ready otherwise.

@davidfischer
Copy link
Contributor

@davidfischer davidfischer commented Mar 13, 2018

Actually I may have butchered this. I'm going to see if I can fix it.

@davidfischer
Copy link
Contributor

@davidfischer davidfischer commented Mar 13, 2018

I had to rebase this but I believe we are now ready.

@davidfischer davidfischer merged commit 74bbb3a into readthedocs:master Mar 14, 2018
1 check passed
@davidfischer
Copy link
Contributor

@davidfischer davidfischer commented Mar 14, 2018

Thank you very much for the contribution! This is fantastic.

@bansalnitish
Copy link
Contributor Author

@bansalnitish bansalnitish commented Mar 14, 2018

Thank you @davidfischer! I am more than happy to contribute 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants