Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#3718: Added date to changelog #3788

Merged
merged 2 commits into from Mar 29, 2018
Merged

#3718: Added date to changelog #3788

merged 2 commits into from Mar 29, 2018

Conversation

@rajujha373
Copy link
Contributor

@rajujha373 rajujha373 commented Mar 13, 2018

This PR is in reference to PR #3727
@humitos @stsewd Please have a look to the changes made here
screenshot from 2018-03-14 00-29-37

Copy link
Member

@humitos humitos left a comment

Nice work!

@rajujha373
Copy link
Contributor Author

@rajujha373 rajujha373 commented Mar 13, 2018

Thank You @humitos :) :)

Copy link
Contributor

@agjohnson agjohnson left a comment

Noted a more proper reST use

@@ -1,5 +1,7 @@
{{header}}
{{toHeader header "-"}}

Date: {{date}}
Copy link
Contributor

@agjohnson agjohnson Mar 23, 2018

Copy link
Contributor Author

@rajujha373 rajujha373 Mar 26, 2018

Hi @agjohnson , I have made the changes. Do guide me if anything more has to be done :)

@rajujha373
Copy link
Contributor Author

@rajujha373 rajujha373 commented Mar 29, 2018

Hi @agjohnson just wanted to know the status of the PR. Is there anything to be updated from my side?

@agjohnson
Copy link
Contributor

@agjohnson agjohnson commented Mar 29, 2018

@rajujha373 probably not, review just takes some time on our end.

@agjohnson agjohnson merged commit 4b28325 into readthedocs:master Mar 29, 2018
1 check failed
@rajujha373
Copy link
Contributor Author

@rajujha373 rajujha373 commented Mar 29, 2018

Thank you :) @agjohnson 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants