Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use JSONP for sustainability API #3789

Merged

Conversation

@davidfischer
Copy link
Contributor

@davidfischer davidfischer commented Mar 13, 2018

  • Remove CORS workaround
- Remove CORS workaround
Copy link
Member

@ericholscher ericholscher left a comment

Looks good.

@@ -128,41 +110,53 @@ Promo.prototype.post_promo_display = function () {
};

function init() {
var post_data = {};
var get_data = {format: "jsonp"};
Copy link
Member

@ericholscher ericholscher Mar 14, 2018

Maybe just call this data or request_data, so it doesn't require changing based on get/post? Not important, though :)

@davidfischer davidfischer merged commit ca35951 into readthedocs:master Mar 26, 2018
1 check passed
@davidfischer davidfischer deleted the sustainability-api-jsonp branch Sep 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants