Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix page redirect preview #3811

Merged
merged 3 commits into from Apr 17, 2018
Merged

Fix page redirect preview #3811

merged 3 commits into from Apr 17, 2018

Conversation

@vidartf
Copy link
Contributor

@vidartf vidartf commented Mar 16, 2018

Superseeds #2711. Closes #2380.

rixx and others added 2 commits Mar 9, 2017
@stsewd
Copy link
Member

@stsewd stsewd commented Mar 16, 2018

Can you rebase against master? New rules for js were added since the original PR :)

@stsewd
Copy link
Member

@stsewd stsewd commented Mar 16, 2018

mmm, the changes are on the template, so doesn't matter. But I think the new rules for js require using ;

@vidartf
Copy link
Contributor Author

@vidartf vidartf commented Mar 16, 2018

@vidartf
Copy link
Contributor Author

@vidartf vidartf commented Apr 12, 2018

Does this need anything else to be considered for merge? Can it be considered reviewed as this is the result of the review in #2711?

stsewd
stsewd approved these changes Apr 13, 2018
Copy link
Member

@stsewd stsewd left a comment

LGTM

@RichardLitt
Copy link
Member

@RichardLitt RichardLitt commented Apr 13, 2018

@vidartf Apologies for the delay! Sometimes we take a while to merge open PRs, even if they look fine. Someone from @core will review this as soon as they have some space, at which point we'll get some more feedback to you or merge it. Thanks for understanding.

Copy link
Member

@humitos humitos left a comment

Thanks @vidartf for you time working on this!

@humitos humitos merged commit ea0ed48 into readthedocs:master Apr 17, 2018
1 check passed
@vidartf vidartf deleted the ticket_2380 branch Apr 18, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

5 participants