Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove pinned CSS Select version #3813

Merged
merged 3 commits into from Mar 26, 2018

Conversation

@davidfischer
Copy link
Contributor

@davidfischer davidfischer commented Mar 16, 2018

CSSSelect is not invoked directly but instead used by PyQuery. After upgrading PyQuery in #2916 the new version now requires a newer version of CSSSelect.

If we want to be super explicit, we should specify the version of CSSSelect right next to where we specify PyQuery rather than in a separate file. The separate file was particularly bad because a different version of CSSSelect ran in testing vs production/deploy.

Copy link
Member

@humitos humitos left a comment

Makes sense to me.

The tests aren't passing because an unrelated linting issue.

(I suppose that our linting packages were upgraded and they are more strict now --but we can address that in a different PR)

@humitos
Copy link
Member

@humitos humitos commented Mar 22, 2018

I think this one can be merged.

@davidfischer
Copy link
Contributor Author

@davidfischer davidfischer commented Mar 26, 2018

I merged master in to fix the tests so I can merge this.

@davidfischer davidfischer merged commit 5a39385 into readthedocs:master Mar 26, 2018
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants