Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pin astroid to fix linter issue on travis #3816

Merged
merged 2 commits into from Mar 20, 2018

Conversation

@stsewd
Copy link
Member

@stsewd stsewd commented Mar 16, 2018

I think this is a bug on pylint-django PyCQA/pylint-django#117 (comment)

I tried with pylint==1.8.2 but didn't solve the problem.

@stsewd
Copy link
Member Author

@stsewd stsewd commented Mar 16, 2018

Related PR where this is exposed #3813

Copy link
Member

@humitos humitos left a comment

Thanks to fix this!

astroid==1.6.2 was released today and if this contains that bug, that's why it started to happen.

I suggest you to add a comment before the pinned package about why this is happening and a link to the issue also. This is useful later when we want to upgrade, we will know what was happening and can be sure that it's already fixed.

@agjohnson agjohnson merged commit 673bfc7 into readthedocs:master Mar 20, 2018
1 check passed
@stsewd stsewd deleted the fix-linter-issue branch Mar 20, 2018
@stsewd
Copy link
Member Author

@stsewd stsewd commented Apr 5, 2018

PyCQA/pylint-django#117 was closed today (PyCQA/pylint-django@abd1164). So in some days/weeks? we can try to unpin/update astroid.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants