Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pointed users to Python3.6 #3817

Merged
merged 1 commit into from May 24, 2018
Merged

Pointed users to Python3.6 #3817

merged 1 commit into from May 24, 2018

Conversation

@varunotelli
Copy link
Contributor

@varunotelli varunotelli commented Mar 17, 2018

Removed the warning and pointed users to python3.6 as suggested in PR #3814

@stsewd
Copy link
Member

@stsewd stsewd commented Mar 17, 2018

Hi @varunotelli I see you made 3 PRs for the same issue, you don't need do to that, you can push to the same branch and GitHub will update the PR. Let me know if you need more help.

@varunotelli
Copy link
Contributor Author

@varunotelli varunotelli commented Mar 17, 2018

@stsewd this is my first time contributing so i didn't clone the repo and just edited the doc online. Sorry about that.

@stsewd
Copy link
Member

@stsewd stsewd commented Mar 18, 2018

@varunotelli you can check this #3766 (comment) for learning more about git and GitHub

Copy link
Member

@humitos humitos left a comment

Hey, thanks for your contrubution! The changes look great 👍 to me.

@humitos
Copy link
Member

@humitos humitos commented Mar 23, 2018

Linting errors are unrelated and fixed in master.

Copy link
Member

@berkerpeksag berkerpeksag left a comment

@varunotelli could you also update your branch? I think it's now possible to do it via GitHub UI. It should show a button like "sync your branch" or "update your branch" (I don't remember the exact wording)

virtual environment will make the installation easier, and will help to avoid
clutter in your system-wide libraries. You will also need Git_ in order to
clone the repository. If you plan to import Python 3 project to your RTD then you'll
need to install Python 3 with virtualenv in your system as well.
clone the repository. If you plan to import Python 2.7 project to your RTD then you'll
Copy link
Member

@berkerpeksag berkerpeksag Apr 16, 2018

I think we can just drop this sentence. Python 2 will stay installed on most systems if I remember correctly. There is a proposal to link python to python3 or python3.X on some systems, but I doubt that will be accepted by Guido or other Python core developers.

@varunotelli
Copy link
Contributor Author

@varunotelli varunotelli commented Apr 16, 2018

@humitos Done

@ericholscher
Copy link
Member

@ericholscher ericholscher commented May 24, 2018

Thanks for this PR!

@ericholscher ericholscher merged commit 034b9ba into readthedocs:master May 24, 2018
1 check failed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

5 participants