Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix up some of the logic around repo and submodule URLs #3860

Merged
merged 2 commits into from Mar 29, 2018

Conversation

@agjohnson
Copy link
Contributor

@agjohnson agjohnson commented Mar 26, 2018

  • Add conditional logic for submodule relative urls
  • Break down logic a bit more
  • Add test case for relative url submodule
  • Broke test case for invalid url submodule

Fixes #3857

* Add conditional logic for submodule relative urls
* Break down logic a bit more
* Add test case for relative url submodule
* Broke test case for invalid url submodule

Fixes #3857
@agjohnson agjohnson requested a review from Mar 26, 2018
@agjohnson
Copy link
Contributor Author

@agjohnson agjohnson commented Mar 26, 2018

Marked a test xfail for not to not block deploy today. We'll want to create a ticket to resovle

@agjohnson
Copy link
Contributor Author

@agjohnson agjohnson commented Mar 29, 2018

Merging as @humitos and I paired on this and no review happened otherwise.

@agjohnson agjohnson merged commit 873108b into master Mar 29, 2018
1 check passed
@agjohnson agjohnson deleted the agj/hotfix-submodule-rel-url branch Mar 29, 2018
env=env
))
log.info(check_output(['git', 'add', '.'], env=env))
log.info(check_output(['git', 'commit', '-m"Add relative submodule"'], env=env))
# Add an invalid submodule URL in the invalidsubmodule branch
log.info(check_output(['git', 'checkout', '-b', 'invalidsubmodule', 'master'], env=env))
Copy link
Member

@humitos humitos Mar 30, 2018

Now this invalidsubmodule is no more invalid.

We probably need to remove this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants