Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed footer ads again #3895

Merged

Conversation

@davidfischer
Copy link
Contributor

@davidfischer davidfischer commented Apr 3, 2018

This change allows displaying a fixed footer promo ad.

  • This is an alternative ad to the sidebar and existing footer ads. It would be instead of a sidebar or footer ad and not in addition to another ad
  • It is for mobile devices only.
  • It supports all themes (but is only on for the themes with ads already)
  • It only supports text (no images).
  • vendors a JS browser detection library to detect mobile. This adds ~7KB to our bundle which should be less than ~1kb gzipped.
  • a side effect is that it needed to push up the version selector flyout menu so they aren't obscured.

screen shot 2018-04-03 at 3 05 25 pm

@davidfischer davidfischer requested a review from ericholscher Apr 3, 2018
@davidfischer davidfischer mentioned this pull request Apr 3, 2018
Copy link
Member

@ericholscher ericholscher left a comment

Looks simple enough. I'd be up for testing this with a community ad in the near future.

Loading

@davidfischer davidfischer merged commit 91ba549 into readthedocs:master Apr 4, 2018
1 check passed
Loading
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants