Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Save Docker image data in JSON file only for DockerBuildEnvironment #3897

Merged
merged 1 commit into from Apr 5, 2018

Conversation

@humitos
Copy link
Member

@humitos humitos commented Apr 4, 2018

Avoid failing when using LocalBuildEnvironment. This was trying to access a specific value defined only in DockerBuildEnvironment and it doesn't make sense to have them in other environments.

@humitos humitos requested a review from davidfischer Apr 4, 2018
Copy link
Contributor

@davidfischer davidfischer left a comment

This makes sense and worked for my LocalBuildEnvironment setup.

Loading

@humitos
Copy link
Member Author

@humitos humitos commented Apr 4, 2018

I think we can merge this but let's wait some time for an @agjohnson review, I suppose.

Loading

@humitos humitos requested a review from agjohnson Apr 5, 2018
Copy link
Contributor

@agjohnson agjohnson left a comment

LGTM

Loading

@agjohnson agjohnson merged commit 2c9e62d into master Apr 5, 2018
1 check passed
Loading
@agjohnson agjohnson deleted the humitos/localbuildenv/image-hash branch Apr 5, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants