Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixup DJANGO_SETTINGS_SKIP_LOCAL in tests #3899

Merged
merged 1 commit into from Apr 17, 2018

Conversation

@xrmx
Copy link
Contributor

@xrmx xrmx commented Apr 4, 2018

The import path for the local_settings should be relative to the
test module and not absolute otherwise the import will fail.

The import path for the local_settings should be relative to the
test module and not absolute otherwise the import will fail.
@humitos
Copy link
Member

@humitos humitos commented Apr 4, 2018

What was the error that you were receiving without this patch?

How I can reproduce it?

Loading

@xrmx
Copy link
Contributor Author

@xrmx xrmx commented Apr 5, 2018

Just add some options in local_settings.py, run the tests and you see they are ignored. In my case i've added a DATABASES entry, removed DJANGO_SETTINGS_SKIP_LOCAL=False from tox.ini and run tox.

Loading

@xrmx
Copy link
Contributor Author

@xrmx xrmx commented Apr 11, 2018

And also settings/dev.py use the dotted import :)

Loading

@xrmx
Copy link
Contributor Author

@xrmx xrmx commented Apr 17, 2018

Friendly ping, this is a really trivial issue :)

Loading

@agjohnson
Copy link
Contributor

@agjohnson agjohnson commented Apr 17, 2018

This looks fine, as it mimics dev.py. It's better to rely on a custom settings file for your tests however, not local_settings.

Loading

@agjohnson agjohnson merged commit 3934c35 into readthedocs:master Apr 17, 2018
1 check passed
Loading
@xrmx xrmx deleted the testskiplocal branch May 29, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants