Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

This fixes two bugs apparent in nesting of translations in subprojects #3909

Merged
merged 2 commits into from Apr 6, 2018

Conversation

@agjohnson
Copy link
Contributor

@agjohnson agjohnson commented Apr 5, 2018

The canonical domain was not searching as deep as we support. We support
translations nested in subprojects, and vice versa, this was previously only
searching for translation or subproject, so no nesting at all.

The path was also a similar problem, but instead of a heavy refactor that reused
the canonical domain lookup, I just altered the logic a little here. The pattern
was required to support both superproject as a translation project and
subproject as a translation project.

The canonical domain was not searching as deep as we support. We support
translations nested in subprojects, and vice versa, this was previously only
searching for translation or subproject, so no nesting at all.

The path was also a similar problem, but instead of a heavy refactor that reused
the canonical domain lookup, I just altered the logic a little here. The pattern
was required to support both superproject as a translation project and
subproject as a translation project.
@agjohnson agjohnson requested a review from Apr 5, 2018
@agjohnson agjohnson added this to the Serving stability milestone Apr 5, 2018
Also lints our test file
humitos
humitos approved these changes Apr 6, 2018
Copy link
Member

@humitos humitos left a comment

This was very hard to follow but it had more sense with the tests.

I try this new test without the new logic and then failed. After I added the new logic and the tests passed.

I don't follow this nested relationship in a 100% but it seems right, though.

@agjohnson agjohnson merged commit b3686ca into master Apr 6, 2018
1 check passed
@agjohnson agjohnson deleted the agj/resolve-nested-translations branch Apr 6, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants