Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable ads on the readthedocs mkdocs theme #3922

Merged

Conversation

@davidfischer
Copy link
Contributor

@davidfischer davidfischer commented Apr 7, 2018

This PR enables ads on the readthedocs theme for projects using Markdown.

Before merging, we should probably notify users of the mkdocs theme.

NOTE: #3920 should probably be merged first as some themes are incorrectly identified as the readthedocs theme. It isn't strictly critical as it is unlikely that the ad injection selectors will match on a custom theme and so it will likely just result in API calls that don't result in an ad being displayed.

SCREENSHOTS
screen shot 2018-04-06 at 5 12 34 pm
screen shot 2018-04-06 at 5 13 32 pm
screen shot 2018-04-06 at 5 14 53 pm

@davidfischer davidfischer requested a review from ericholscher Apr 7, 2018
@agjohnson agjohnson removed the Mkdocs label Apr 10, 2018
@agjohnson agjohnson added this to the Mkdocs milestone Apr 10, 2018
@agjohnson agjohnson removed this from the Mkdocs milestone Apr 11, 2018
@agjohnson agjohnson added this to the 2.4 milestone Apr 11, 2018
Copy link
Member

@ericholscher ericholscher left a comment

Looks good.

Loading

@davidfischer
Copy link
Contributor Author

@davidfischer davidfischer commented Apr 27, 2018

I emailed all users who are owners of an mkdocs project.

Loading

@davidfischer davidfischer merged commit b05c82a into readthedocs:master May 16, 2018
1 check passed
Loading
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants