Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed footer ad width fix #3944

Merged

Conversation

@davidfischer
Copy link
Contributor

@davidfischer davidfischer commented Apr 13, 2018

This is a fix in case content on the page causes the <body> width to exceed the viewport width.

vw is understood by basically every browser visiting our site (IE9+, Chrome, FF, Safari) except Opera Mini. For this case, 100% is used as a fallback. https://caniuse.com/#search=vw

Here's the issue I'm trying to fix:
screen shot 2018-04-13 at 11 34 33 am

@davidfischer davidfischer requested a review from ericholscher Apr 13, 2018
@agjohnson agjohnson added this to the 2.4 milestone Apr 13, 2018
@davidfischer davidfischer merged commit 4d9aee2 into readthedocs:master Apr 16, 2018
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants