Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make adjustments to Projects page #3948

Merged
merged 1 commit into from Apr 17, 2018
Merged

Make adjustments to Projects page #3948

merged 1 commit into from Apr 17, 2018

Conversation

@ze
Copy link
Contributor

@ze ze commented Apr 15, 2018

Going over the changes:

.quiet was removed because it was already defined elsewhere, which didn't make much sense. The line of duplication is line 46.

#content #project_description was simplified to just #project_description.

I also made the decision to make the margin-bottom a margin-top because it does nothing otherwise. An example in practice is godot. And if you are to look at the HTML file, its going to end up rendered at the bottom. Essentially, it's useless and I think it was meant for it to be a top margin such that there would be appropriate spacing.

I also adjusted the template in project_details.html such that it removed the extra id and needless div, and would not leave an empty div in case of there not being a description. That way, it fits the purpose of templating better.

Change margins on #project_description to what it seems it was intended to be
Adjust project description template
@@ -129,7 +129,7 @@ form.form-wide textarea {
#content { padding: 50px 0; }
#content ul { margin-bottom: 20px; }

#content #project_description { margin-bottom: 20px; }
#project_description { margin-top: 20px; }
Copy link
Member

@stsewd stsewd Apr 15, 2018

It always bothered me to see those elements too close p:

Copy link
Contributor

@davidfischer davidfischer left a comment

Thanks for your first contribution!

This is great and every change improves things. 👍

@davidfischer davidfischer merged commit fbc52d5 into readthedocs:master Apr 17, 2018
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants