Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make resolve_domain work when a project is subproject of itself #3962

Merged
merged 1 commit into from Apr 18, 2018

Conversation

@humitos
Copy link
Member

@humitos humitos commented Apr 18, 2018

This is an invalid db state since this relationship is not possible, but there are some old project that has this relationship and we want to avoid breaking the code for this cases.

Copy link
Member

@ericholscher ericholscher left a comment

Looks good.

@humitos
Copy link
Member Author

@humitos humitos commented Apr 18, 2018

Mmm... this didn't trigger a travis build.

This is an invalid db state since this relationship is not possible,
but there are some old project that has this relationship and we want
to avoid breaking the code for this cases.
@humitos humitos force-pushed the humitos/resolver/subproject-itself branch from 1bca764 to 823707d Apr 18, 2018
@humitos
Copy link
Member Author

@humitos humitos commented Apr 18, 2018

I just rebased trying to trigger a travis build.

@stsewd
Copy link
Member

@stsewd stsewd commented Apr 18, 2018

@humitos you can restart the build from travis itself.

@davidfischer
Copy link
Contributor

@davidfischer davidfischer commented Apr 18, 2018

@stsewd normally you can. However, we looked and couldn't find that option since Travis never triggered a build in the first place.

@agjohnson
Copy link
Contributor

@agjohnson agjohnson commented Apr 18, 2018

Lint error looks unrelated, I'll force merge.

@agjohnson agjohnson merged commit 3c581d8 into master Apr 18, 2018
1 check failed
@agjohnson agjohnson deleted the humitos/resolver/subproject-itself branch Apr 18, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

5 participants