Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix recursion problem more generally #3989

Merged
merged 3 commits into from Apr 20, 2018
Merged

Fix recursion problem more generally #3989

merged 3 commits into from Apr 20, 2018

Conversation

@agjohnson
Copy link
Contributor

@agjohnson agjohnson commented Apr 20, 2018

Remove previous fixes that were trying to catch specific cases, apply a general
solution that tests if we're in a loop.

Remove previous fixes that were trying to catch specific cases, apply a general
solution that tests if we're in a loop.
@agjohnson agjohnson requested a review from Apr 20, 2018
@agjohnson agjohnson added this to the 2.4 milestone Apr 20, 2018
# recursion. We can't determine a root project well here, so you get
# what you get if you have configured your project in a strange manner
if projects is None:
projects = [project]
Copy link
Contributor

@davidfischer davidfischer Apr 20, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't you want an else here that does projects.append(project)?

Loading

Copy link
Contributor Author

@agjohnson agjohnson Apr 20, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oops, yes, that is the missing piece

Loading

Copy link
Contributor

@davidfischer davidfischer left a comment

I just reviewed visually but I believe we are good.

Loading

@agjohnson
Copy link
Contributor Author

@agjohnson agjohnson commented Apr 20, 2018

I added one last test to ensure deeper nesting was tested, no logic changed though

Loading

@agjohnson agjohnson merged commit 9fcf878 into master Apr 20, 2018
1 check passed
Loading
@agjohnson agjohnson deleted the agj/another-recursion-fix branch Apr 20, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants