Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove build queue length warning on build list page #4018

Merged
merged 1 commit into from Apr 27, 2018

Conversation

@agjohnson
Copy link
Contributor

@agjohnson agjohnson commented Apr 25, 2018

This piece of UI was never updated to fit somewhere more cohesive in the UI and
I feel is a strange thing to expose directly to users. I think a better
application for this is in an eventual status page. A status page is not a
priority atm though.

This piece of UI was never updated to fit somewhere more cohesive in the UI and
I feel is a strange thing to expose directly to users. I think a better
application for this is in an eventual status page. A status page is not a
priority atm though.
@agjohnson agjohnson added this to the 2.4 milestone Apr 25, 2018
@agjohnson agjohnson requested a review from Apr 25, 2018
@ericholscher
Copy link
Member

@ericholscher ericholscher commented Apr 25, 2018

I'm -0 on removing this. I think it's valuable for users who just see their build stuck in a Triggered state. What is the proposed replacement here? Just let users see their builds hang?

@humitos
Copy link
Member

@humitos humitos commented Apr 25, 2018

Maybe instead of fully removing it, just changing the wording/copy?

I don't think it's really useful to know as a user that there is a queue of 150 tasks.

Also, not sure but, the word Triggered isn't enough to communicate that it was "launched but not started yet"?

@ericholscher
Copy link
Member

@ericholscher ericholscher commented Apr 25, 2018

Yea, I think something along the lines of "We're experiencing an issue that might cause builds to be delayed" or something would be better than just removing this and having users have no knowledge that things are backed up, but will process.

@agjohnson
Copy link
Contributor Author

@agjohnson agjohnson commented Apr 25, 2018

It was originally added when we had frequent build back ups. We don't have this problem anymore so this has turned into more of a liability and poor UI. It shows most commonly on the .com, where exposing queue depth is a bad idea. Currently, I just want this feature gone because of this. I think a better UI/UX is to show an alert state on each hanging build in the build list and on the build detail page if build.state == triggered and build.date > 5m ago. We don't need to hit redis at all for this.

@ericholscher
Copy link
Member

@ericholscher ericholscher commented Apr 27, 2018

Cool. I guess we can worry about it again if we start getting a lot of queue backups. At least the build objects are created now, as opposed to the old days where it was just sending builds into the abyss :)

@ericholscher ericholscher merged commit 08eed81 into master Apr 27, 2018
1 check passed
@agjohnson
Copy link
Contributor Author

@agjohnson agjohnson commented Apr 27, 2018

And the hanging build objects are finally shown as terminated too! I think a lot of users assumed their builds were destroying our systems as they sat there.

I'll create an issue for updating the build list.

@agjohnson agjohnson deleted the agj/remove-queue-length branch Apr 27, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants