Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove dead code from api v1 #4038

Merged
merged 1 commit into from Apr 30, 2018

Conversation

@stsewd
Copy link
Member

@stsewd stsewd commented Apr 27, 2018

sync_versions have methods that doesn't exists like _sync_versions and _delete_versions, so it always was throwing an exception. This was used internally only, and now we use the sync_versions from the apiv2.

Some comments about this #3887 (comment)

@agjohnson agjohnson added this to the Cleanup milestone Apr 27, 2018
@ericholscher ericholscher merged commit ce0b114 into readthedocs:master Apr 30, 2018
1 check passed
@ericholscher
Copy link
Member

@ericholscher ericholscher commented Apr 30, 2018

Thanks!

@stsewd stsewd deleted the remove-dead-code-apiv1 branch Apr 30, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants