Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix missing fonts #4060

Merged
merged 1 commit into from May 22, 2018
Merged

Fix missing fonts #4060

merged 1 commit into from May 22, 2018

Conversation

@davidfischer
Copy link
Contributor

@davidfischer davidfischer commented May 4, 2018

If you load a docs page like https://docs.readthedocs.io/en/latest/ you see that there are some missing fonts in the console. Some of these show up as CORS issues but that is a red herring because the request 404-ed.

Access to Font at 'https://media.readthedocs.org/fonts/fontawesome-webfont.woff2?v=4.7.0' from origin 'https://docs.readthedocs.io' has been blocked by CORS policy: No 'Access-Control-Allow-Origin' header is present on the requested resource. Origin 'https://docs.readthedocs.io' is therefore not allowed access. The response had HTTP status code 404.
Access to Font at 'https://media.readthedocs.org/fonts/Lato-Italic.ttf' from origin 'https://docs.readthedocs.io' has been blocked by CORS policy: No 'Access-Control-Allow-Origin' header is present on the requested resource. Origin 'https://docs.readthedocs.io' is therefore not allowed access. The response had HTTP status code 404.

This PR fixes this issue. The 2 fonts included with this PR come directly from bower.

Replaces #3602

@davidfischer davidfischer requested a review from agjohnson May 4, 2018
@agjohnson agjohnson merged commit a63702e into readthedocs:master May 22, 2018
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants