Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Gold Member marketing #4063

Merged

Conversation

@davidfischer
Copy link
Contributor

@davidfischer davidfischer commented May 5, 2018

Changes

In general, the goal of this PR is to update some of our marketing and documentation to better reflect the reality at Read the Docs.

Here's an overview of the changes:

  • Make it more obvious that becoming a Gold Member removes advertising
  • Try to standardize on the terminology "Gold Member" rather than "buying gold" or anything else.
  • Explain about RTD advertising in the user profile where users can go community-only, donate, or otherwise opt-out/-in
  • When settings.USE_PROMOS = False, remove the links to manage advertising.

One change I did not do but am considering is to allow staying logged-in longer than 2 weeks. This becomes somewhat important when users are becoming a Gold Member to skip ads. Having people log in every two weeks seems suboptimal.

@davidfischer davidfischer requested a review from ericholscher May 5, 2018
@davidfischer
Copy link
Contributor Author

@davidfischer davidfischer commented May 7, 2018

I don't think this lint error is related to these changes...

{% endblocktrans %}
</p>

{% if request.user.gold.count or request.user.goldonce.count %}
Copy link
Member

@humitos humitos May 14, 2018

I think you can use .exists here instead of .count

@davidfischer
Copy link
Contributor Author

@davidfischer davidfischer commented May 15, 2018

Updated based on feedback.

Copy link
Member

@ericholscher ericholscher left a comment

Looks like a good rework. I think the Gold page probably needs a larger rework, but that can be done after this.

@@ -135,6 +135,9 @@ Opting Out

We have added multiple ways to opt out of the advertising on Read the Docs.

Users can go ad-free for as long as they are logged-in
by becoming a `Gold Member to Read the Docs <https://readthedocs.org/accounts/gold/>`_.
Copy link
Member

@ericholscher ericholscher May 18, 2018

For some reason the to feels weird here. I guess it implies a subscription? That makes sense, just reads weird to me and I'm not 100% sure why.

Copy link
Contributor Author

@davidfischer davidfischer May 18, 2018

I think of is better than to.

docs/support.rst Outdated
nobody is paid to handle readthedocs.org support.
We are hoping to bring in enough money with our `Gold`_ program to change that,
so please sign up if you are able.
Read the Docs is a community- and ad-supported site.
Copy link
Member

@ericholscher ericholscher May 18, 2018

community- is a bit odd here. I think maybe reword it:

Read the Docs is supported by community contributions and advertising.

@@ -59,6 +59,9 @@ <h2>Read the Docs Gold</h2>
we suggest giving at least $20/month to help cover our support and operations costs.
Copy link
Member

@ericholscher ericholscher May 18, 2018

I feel like these other parts of the page are just blabbing in an awkward way also. I'm almost tempted to just remove them?

Copy link
Contributor Author

@davidfischer davidfischer May 18, 2018

I'll give it a read and see if there's anything that should be removed. I tried to remove anything inaccurate already.

Copy link
Contributor Author

@davidfischer davidfischer May 18, 2018

I do think everything around domains can be deleted once we get Lets Encrypt support. I don't quite think I'll delete that yet.

Copy link
Member

@ericholscher ericholscher May 21, 2018

Why would LE support change our infra cost for domains? If anything, it would increase the overhead we have for each domain we serve, managing the certs, etc.

@@ -279,3 +280,34 @@ def profile_detail(

context.update({'profile': profile_obj})
return render(request, template_name, context=context)


def account_advertising(request):
Copy link
Member

@ericholscher ericholscher May 18, 2018

Does this need a login_requires decorator? Guessing it will blow up with a non-logged in user otherwise?

@davidfischer
Copy link
Contributor Author

@davidfischer davidfischer commented May 21, 2018

Why would LE support change our infra cost for domains?

It would be fully automated at that point. There would be no marginal cost to additional domains once the work on LE is done. Currently there's a manual step there.

@ericholscher
Copy link
Member

@ericholscher ericholscher commented May 21, 2018

What manual step? We don't support SSL at all for them currently. The idea was for people using CNAME's to pay more, because they were getting more value and we were getting less brand awareness.

@davidfischer
Copy link
Contributor Author

@davidfischer davidfischer commented May 21, 2018

Ahhh. I thought we did support it if they gave us the cert. I guess not.

@davidfischer davidfischer merged commit b79158f into readthedocs:master May 22, 2018
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants