Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update the documentation_type when it's set to 'auto' #4080

Merged
merged 1 commit into from May 18, 2018

Conversation

@humitos
Copy link
Member

@humitos humitos commented May 10, 2018

When the project.documentation_type is set to auto we are protecting ourselves by updating it at build time to sphinx. At this point we also update our project memory instance, but we were missing to update the project memory instance that lives inside the version memory instance.

Closes #3980

When the `project.documentation_type` is set to `auto` we are
protecting ourselves by updating it at build time to `sphinx`. At this
point we also update our project memory instance, but we were missing
to update the project memory instance that lives inside the version
memory instance.
@ericholscher
Copy link
Member

@ericholscher ericholscher commented May 18, 2018

Was wondering where those errors were coming from :)

@ericholscher ericholscher merged commit 4b83d92 into master May 18, 2018
1 check passed
@humitos humitos deleted the humitos/doctype/auto branch May 21, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants